Further work in 'lax mode' #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have executed all 1708 tests and made a first pass at recording the known issues. I have also made quite a few changes to the 'lax mode' path expressions. It is going to take a few iterations to find the expressions that work for all the different apps! I have also temporarily disabled the persistence test, it fails intermitently at the moment.
| @@ -10,6 +10,15 @@ var frameworkNamePattern = /^[a-z-_]+$/; | |||
| // not worth testing via a generic mecanism | |||
| var excludedFrameworks = ['gwt', 'polymer']; | |||
|
|
|||
| // these implementations cannot be run offline, because they are hosted | |||
| excludedFrameworks = excludedFrameworks.concat(['derby', 'firebase-angular', 'meteor', 'socketstream', | |||
There was a problem hiding this comment.
all but the firebase one can be run offline, though requires us to start a server with npm start.
There was a problem hiding this comment.
Thanks for the info. I might raise a few issues regarding the automated tests as a better way to track my 'TODOs'
sindresorhus
added a commit
that referenced
this pull request
Feb 3, 2014
Further work in 'lax mode'
|
This is getting really good. Can't wait for us to be able to integrate with Travis and just have a PR fail if it doesn't pass. |
|
!!! Travis integration is gonna be sooo good! |
|
I agree - travis integration would be awesome. I am almost done with a full test of all the apps. Once I have discovered all the current bugs I can start looking at getting it working with Phantom. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have executed all 1708 tests and made a first pass at recording the known issues. I have also made quite a few changes to the 'lax mode' path expressions. It is going to take a few iterations to find the expressions that work for all the different apps!
I have also temporarily disabled the persistence test, it fails intermitently at the moment.
Some of the code needs a bit of a refactor, but right now I am focussed on the goal of collecting up all the issues :-)